feat: Improve usability of dockerode wrapper #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Mar 22, 2024
artonge
approved these changes
Mar 25, 2024
Pytal
reviewed
Mar 26, 2024
Pytal
approved these changes
Mar 26, 2024
susnux
force-pushed
the
feat/allow-mounts-and-force
branch
from
5072a4a
to
0589bfd
Compare
* Export `getContainer` and `getContainerName` functions This can be used to e.g. create the `runOCC` cypress command * Make the container name dependent on the current app to prevent issues when reusing containers * Allow to pass options for container creation to the `startNextcloud` function * `forceRecreate` to not reuse any container but force creating a new one * `mounts` to allow binding other directories to the container (e.g. server config) * Allow to expose a port Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/allow-mounts-and-force
branch
from
0589bfd
to
65f3597
Compare
susnux
added a commit
that referenced
this pull request
Apr 16, 2024
Enhancements ✨ ----------------------- * feat: Improve usability of dockerode wrapper by @susnux in #486 * Export getContainer and getContainerName functions This can be used to e.g. create the runOCC cypress command * Make the container name dependent on the current app to prevent issues when reusing containers * Allow to pass options for container creation to the startNextcloud function forceRecreate to not reuse any container but force creating a new one mounts to allow binding other directories to the container (e.g. server config) Bugfixes 🐛 -------------- * fix: Update npm version to current LTS and update dev dependencies by @susnux in #509 Changed ------- * Dependency updates Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getContainerandgetContainerNamefunctions This can be used to e.g. create therunOCCcypress commandstartNextcloudfunctionforceRecreateto not reuse any container but force creating a new onemountsto allow binding other directories to the container (e.g. server config)