fix(vue3): align rules with Vue 2 rules #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
skjnldsv
approved these changes
May 16, 2024
|
Ok for me, no strong opinion :) |
Just for the record, I'd prefer to have those rules, but I don't want to make the difference between Vue 2 and Vue 3 huge during the migration period. |
Merged
|
I would prefer to stick with vue guidelines here too, but makes migration harder |
susnux
reviewed
May 16, 2024
| // Prevent conflicts with native HTML elements | ||
| 'vue/multi-word-component-names': 'error', | ||
| // Allow single-word components names | ||
| 'vue/multi-word-component-names': ['off'], |
There was a problem hiding this comment.
should be warning in the future, single name is really bad habit.
Alternative solution — change rules for both Vue 2 and Vue 3 (and call it a new major) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I totally agree with the rules, they are much different from our rules for Vue 2 requiring having many formatting changes and even filenames between Vue 2 and Vue 3 apps. It makes diffs and backports complicated during migration period.