Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow to import packages from devDependencies within config files #580

Merged
merged 1 commit into from Jul 11, 2023
Merged

fix: Allow to import packages from devDependencies within config files #580

merged 1 commit into from Jul 11, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 2, 2023

Currently something like this vite.config.js leads to an error:

import { ... } from 'vite'

because vite is only a development dependency.

@susnux susnux requested a review from skjnldsv July 2, 2023 15:11
skjnldsv
skjnldsv reviewed Jul 2, 2023
View reviewed changes
parts/base.js Outdated Show resolved Hide resolved
@susnux
fix: Allow to import packages from devDependencies within config files
540f227 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/allow-import-dev-dependencies-in-config branch from 5e2dd3e to 540f227 Compare July 11, 2023 16:34
@susnux susnux merged commit d23421b into master Jul 11, 2023
5 checks passed
@susnux susnux deleted the fix/allow-import-dev-dependencies-in-config branch July 11, 2023 16:44
@susnux susnux mentioned this pull request Sep 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@susnux @skjnldsv