Allow linting of typescript with module resolution set to node16 or nodenext
#527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6` or `nodenext` Node16 module resolution with Typescript requires every relative import to have a file extension, but Typescript does not allow `.ts` so you have to use `.js`. As this file obviously does not exist on build time, but only after it has been created ESLint will complain about an unresolved import. Fixing it by using a different resolver for this. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/typescript-node16
branch
from
c4780ab
to
6cd3e55
Compare
skjnldsv
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node16 module resolution with Typescript requires every relative import to have a file extension.
Typescript does not allow to use
.tsand then rewriting it after compiling, so you have to use.jsas the output.As this file obviously does not exist on build time (as it needs to be created by Typescript), ESLint complains about an unresolved import. Fixing it by using a different resolver for this.