Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): Update Foursquare profile callback + API version #11348

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix(providers): Update Foursquare profile callback + API version #11348

merged 1 commit into from
Aug 9, 2024

Conversation

MatyiFKBT
Copy link
Contributor

☕️ Reasoning

The Foursquare provider does not work in its current form, because their api returns in the following form:

{ "response":
  { "user": 
    { "id": "...",
      "email": "..."
    }
  }
}

This pull request fixes it and uses the same form with NextAuth v4 as in @auth/core (see here).

I also bumped the apiVersion property to match @auth/core, let me know if I should test it with a newer version, and maybe open a new PR to bump the version,

🧢 Checklist

  • Documentation - no need to update docs in my opinion
  • Tests
  • Ready to be merged

📌 Resources

Sorry, something went wrong.

The Foursquare provider does not work in its current form
@MatyiFKBT MatyiFKBT requested a review from ThangHuuVu as a code owner July 8, 2024 13:27
Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Jul 8, 2024 1:29pm
next-auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 1:29pm

Copy link

vercel bot commented Jul 8, 2024

@MatyiFKBT is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added providers legacy Refers to `next-auth` v4. Minimal maintenance. labels Jul 8, 2024
@balazsorban44 balazsorban44 merged commit 846c3d7 into nextauthjs:v4 Aug 9, 2024
7 of 10 checks passed
@MatyiFKBT MatyiFKBT deleted the patch-1 branch August 12, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy Refers to `next-auth` v4. Minimal maintenance. providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants