Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump Go version to 1.23 #556

Merged
merged 2 commits into from
Mar 12, 2025
Merged

chore: bump Go version to 1.23 #556

merged 2 commits into from
Mar 12, 2025
+27 −14

Conversation

ujwalsah
Copy link
Contributor

Update go version to 1.23

ujwalsah added 2 commits March 10, 2025 11:05
@ujwalsah
chore: go version bump

Verified

This commit was signed with the committer’s verified signature.
rajrohanyadav Rohan Yadav
SSH Key Fingerprint: wYJKypCP5oX9xG/A8MzVBcTfxAMO9pNvB5t8l8L+K7w
Verified
Learn about vigilant mode
Loading
Loading status checks…
95b544a
@ujwalsah
deps: upgrade x/crypto package
4bb0ed0
@ujwalsah ujwalsah requested a review from rajrohanyadav March 10, 2025 06:12
@rajrohanyadav
Copy link
Contributor

Thanks for taking care of this, two questions:

  • Can we update to 1.24 if there are no breaking changes?
  • Did you check the go release notes to ascertain there are no breaking changes or any modifications that might impact our code/product? If yes, can you add the same in the PR description?

@ujwalsah
Copy link
Contributor Author

ujwalsah commented Mar 11, 2025 •
edited
Loading

Thanks for taking care of this, two questions:

  • Can we update to 1.24 if there are no breaking changes?
  • Did you check the go release notes to ascertain there are no breaking changes or any modifications that might impact our code/product? If yes, can you add the same in the PR description?
  1. I checked updating to 1.24 in a separate branch commit and there are breaking changes in that particular go version. We can go ahead and release 1.23 since we have failing check which requires version update.
  2. I checked the go release notes for 1.23 and everything seems fine with that. You can find out more on that here https://go.dev/doc/go1.23

@rajrohanyadav
Copy link
Contributor

Thanks for taking care of this, two questions:

  • Can we update to 1.24 if there are no breaking changes?
  • Did you check the go release notes to ascertain there are no breaking changes or any modifications that might impact our code/product? If yes, can you add the same in the PR description?
  1. I checked updating to 1.24 in a separate branch commit and there are breaking changes in that particular go version. We can go ahead and release 1.23 since we have failing check which requires version update.
  2. I checked the go release notes for 1.23 and everything seems fine with that. You can find out more on that here https://go.dev/doc/go1.23

Thanks. I agree we can release 1.23 update to unblock other PRs, and create a separate PR to bump go to 1.24.

rajrohanyadav
rajrohanyadav approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@rajrohanyadav rajrohanyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujwalsah ujwalsah merged commit d8d243f into master Mar 12, 2025
13 checks passed
@ujwalsah ujwalsah deleted the go-version-update branch March 12, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajrohanyadav rajrohanyadav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ujwalsah @rajrohanyadav