Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix builds because of missing go1.22 package #555

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

ujwalsah
Copy link
Contributor

@ujwalsah ujwalsah commented Mar 6, 2025

After the release the go version 1.24, the go version 1.22 is no longer supported. Hence, hardcoded the go download URL for now to point to go version 1.22.

@ujwalsah ujwalsah requested a review from rajrohanyadav March 6, 2025 07:26
@coveralls
Copy link

coveralls commented Mar 6, 2025

Pull Request Test Coverage Report for Build 13693597727

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.443%

Totals Coverage Status
Change from base Build 12923764593: 0.0%
Covered Lines: 2052
Relevant Lines: 6325

💛 - Coveralls

Verified

This commit was signed with the committer’s verified signature.
rajrohanyadav Rohan Yadav
    * update runner ubuntu version
    * go mod tidy to fix codeql checks
Copy link
Contributor

@rajrohanyadav rajrohanyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajrohanyadav
Copy link
Contributor

Thanks for fixing this, as you pointed out we'll have to find a path forward for the deprecated go version. It is a concern as we won't get any security updates from go team :(

Copy link

@sairaj18 sairaj18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 😃.

I'm assuming this PR check will be fixed by this PR

@ujwalsah ujwalsah merged commit 57a5ccc into master Mar 6, 2025
12 of 13 checks passed
@ujwalsah ujwalsah deleted the broken-pipeline-fix branch March 6, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants