Require OpenStruct where missing in tests #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rake removed its requirement of OpenStruct in version 13.2.0. This caused our stripe multiverse suite to fail. Since our tests were executed using Rake, we were able to use OpenStruct without a require in the file. Now, OpenStruct is explicitly required in all the files it is used.
|
The only failing suite in this PR will be resolved by #2543 |
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
fallwith
approved these changes
Apr 11, 2024
hannahramadan
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rake removed its requirement of OpenStruct in version 13.2.0. This caused our stripe multiverse suite to fail.
Since our tests were executed using Rake, we were able to use OpenStruct without a require in the file.
Now, OpenStruct is explicitly required in all the files it is used.
See: ruby/rake#545
Resolves #2548