Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newrelic_rpm.gemspec #2304

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Update newrelic_rpm.gemspec #2304

merged 2 commits into from
Nov 1, 2023

Conversation

washu
Copy link
Contributor

@washu washu commented Nov 1, 2023

Change rubocop to 1.57.2, as 1.54 breaks an installation using bundler 1.17, fix was posted to robucop and a new release was created.

Before contributing, please read our contributing guidelines and code of conduct.

Overview

This change updates the rubocop version, to one that works in bundler 1 and bundler 2 environments.
1.54 will fail under bundler 1, with conflicting version of base64. the fix in rubocop release corrects this issue

Submitter Checklist:

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

Change rubocop to 1.57.2, as 1.54 breaks an installation using bundler 1.17, fix was posted to robucop and a new release was created.
@CLAassistant
Copy link

CLAassistant commented Nov 1, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Nov 1, 2023
Autocorrections applied by Rubocop v1.57.2 after upgrading from v1.54
@fallwith
Copy link
Contributor

fallwith commented Nov 1, 2023

Thank you, @washu, for helping keep us compatible with Bundler v1 which we still need to test with. Your contribution is much appreciated!

@fallwith fallwith merged commit 68fadc2 into newrelic:dev Nov 1, 2023
24 checks passed
@Earlopain
Copy link
Contributor

This gem itself still depends on base64 like rubocop used to, is that not the same problem for these older bundler versions?

@washu
Copy link
Contributor Author

washu commented Nov 2, 2023

This gem doesnt explicitly require base64 i.e. it doesnt do
s.add_runtime_dependency('base64', '~> 0.1.1') in the gemspec.

Which is what rubocop was doing, they took the same approach rack took, which was jsut implment the encode fucntion and not require the entire gem.

@Earlopain
Copy link
Contributor

Ah, I see. The high version constraint was the problem. I missed that, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs submitted by the community
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants