enable Rack and Puma tests with Ruby 3.3 #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test Ruby 3.3 with Puma (via the Rack suite) now that [puma/puma#3165](puma/puma#3165) has been merged * update `add_version` to respect _any_ prefix a human maintainer might want to specify for a version, and not just `=`
|
resolves #2042
Disregard. We're going to use a SHA and a TODO comment for now, as Puma > v6.3.0 is still nowhere in sight. |
While we continue to wait for a Puma release newer than v6.3.0, let's just go with a SHA for now. That means we need to update our envfile helper to support SHAs. Done.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
send 1 argument, not 2
SimpleCov Report
|
| @@ -114,8 +108,14 @@ def size | |||
| @gemfiles.size | |||
| end | |||
|
|
|||
| def add_version(version, twiddle_wakka = true) | |||
| def add_version(version) | |||
There was a problem hiding this comment.
Sweet edit. Comments were really helpful here
hannahramadan
approved these changes
Aug 10, 2023
kaylareopelle
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_versionto respect any prefix a human maintainer might want to specify for a version, and not just=add_versionto allow you do whatever Bundler lets you do. You can usegithub,git,path, etc.