Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DatasetSearcher class with search methods from Dataset #677

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 28, 2022

Closes #669.

Changes proposed in this pull request:

  • Create a nimare.dataset.DatasetSearcher class with all of the get methods originally in the Dataset class.
  • Move several functions around to deal with circular import issues.
    • We probably need to enforce some kind of import rules for our modules to avoid this kind of situation.

@tsalo tsalo added enhancement New feature or request breaking-change PRs that change results or interfaces. labels Apr 28, 2022
@tsalo tsalo added this to In progress in NIMADS integration via automation Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #677 (bc67dbc) into main (d37c216) will increase coverage by 0.03%.
The diff coverage is 89.76%.

@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   85.32%   85.35%   +0.03%     
==========================================
  Files          41       41              
  Lines        4503     4526      +23     
==========================================
+ Hits         3842     3863      +21     
- Misses        661      663       +2     
Impacted Files Coverage Δ
nimare/utils.py 94.72% <ø> (+0.03%) ⬆️
nimare/workflows/macm.py 25.00% <33.33%> (-0.72%) ⬇️
nimare/meta/kernel.py 80.36% <75.00%> (+0.24%) ⬆️
nimare/dataset.py 89.76% <89.30%> (+0.04%) ⬆️
nimare/meta/utils.py 55.06% <92.30%> (+2.26%) ⬆️
nimare/annotate/cogat.py 91.35% <100.00%> (ø)
nimare/base.py 85.96% <100.00%> (+1.14%) ⬆️
nimare/decode/base.py 91.48% <100.00%> (+0.37%) ⬆️
nimare/decode/continuous.py 94.84% <100.00%> (+0.16%) ⬆️
nimare/extract/utils.py 42.22% <100.00%> (+3.63%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d37c216...bc67dbc. Read the comment docs.

@tsalo tsalo added this to the 0.0.13 milestone Jun 2, 2022
@tsalo tsalo modified the milestones: 0.0.13, 0.0.14 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change PRs that change results or interfaces. enhancement New feature or request
Projects
NIMADS integration
  
In progress
Development

Successfully merging this pull request may close these issues.

Create DatasetSearcher class for transforming Datasets
1 participant