Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send a RST frame when closing the stream in a write future whil… #13973

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Don't send a RST frame when closing the stream in a write future whil… #13973

merged 2 commits into from
Apr 14, 2024

Commits on Apr 12, 2024

  1. Don't send a RST frame when closing the stream in a write future whil… 

    …e processing inbound frames.

Motiviation:

Due a bug in netty we would send a RST frame in some cases even tho we correctly received the endOfStream already. This is not necessary and might even confuse the remote peer.

Modifications:

- Keep track of if we received endOfStream and send endOfStream in our Channel implementation and only send a RST frame if this is not the case during close
- Add unit tests

Result:

Don't send RST frame if we received endOfStream and send endOfStream.
    @normanmaurer
    normanmaurer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a955fcd View commit details
    Browse the repository at this point in the history

  2. cleanup imports

    @normanmaurer
    normanmaurer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    07187b5 View commit details
    Browse the repository at this point in the history