Always increment Stream Id on createStream #13485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecharmon
force-pushed
the
AlwaysIncrementStreamId-12065
branch
from
48b88f3
to
9dae3e3
Compare
|
@alecharmon did you sign our ical yet ? https://netty.io/s/icla |
|
@normanmaurer I did |
hyperxpro
approved these changes
Jul 12, 2023
|
/cc @ejona86 |
|
Also @vietj and @idelpivnitskiy |
normanmaurer
approved these changes
Jul 12, 2023
normanmaurer
requested changes
Jul 12, 2023
codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java
Outdated
Show resolved
Hide resolved
codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java
Show resolved
Hide resolved
alecharmon
force-pushed
the
AlwaysIncrementStreamId-12065
branch
from
9dae3e3
to
a5fc728
Compare
ejona86
approved these changes
Jul 13, 2023
Motivation: When the creation of a stream causes an error for whatever reason we want to increment the next expected stream id. ie: checkNewStreamAllowed raises an error which causes the headers frame to get rejected subsequently a data frame arrives and it throws a protocol error. Modification: Use a finally block so that we always increment the expected next stream id Result: Fixes netty#12065
alecharmon
force-pushed
the
AlwaysIncrementStreamId-12065
branch
from
a5fc728
to
2269e9a
Compare
|
@alecharmon thanks a lot! |
normanmaurer
added a commit
that referenced
this pull request
Jul 19, 2023
Motivation: When the creation of a stream causes an error for whatever reason we want to increment the next expected stream id. ie: checkNewStreamAllowed raises an error which causes the headers frame to get rejected subsequently a data frame arrives and it throws a protocol error. Modification: Use a finally block so that we always increment the expected next stream id Result: Fixes #12065 --------- Co-authored-by: Norman Maurer <norman_maurer@apple.com>
normanmaurer
added a commit
that referenced
this pull request
Jul 27, 2023
…ug which caused sending multiple RST frames for the same id Motivation: This reverts commit 4e1a0c3 as it seems to cause a race in some situations. More investigation needs to be done but for now let's revert it. Modification: Revert commit 4e1a0c3 Result: No more race which cause multiple RST frames to be send for the same stream id.
normanmaurer
added a commit
that referenced
this pull request
Jul 27, 2023
…ug which caused sending multiple RST frames for the same id Motivation: This reverts commit 4e1a0c3 as it seems to cause a race in some situations. More investigation needs to be done but for now let's revert it. Modification: Revert commit 4e1a0c3 Result: No more race which cause multiple RST frames to be send for the same stream id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When the creation of a stream causes an error for whatever reason we want to increment the next expected stream id.
ie: checkNewStreamAllowed raises an error which causes the headers frame to get rejected subsequently a data frame arrives and it throws a protocol error.
Modification:
Use a finally block so that we always increment the expected next stream id
Result:
Fixes #12065