Revert "Always increment Stream Id on createStream (#13485)" to fix b…

…ug which caused sending multiple RST frames for the same id

Motivation:

This reverts commit 4e1a0c3 as it seems to cause a race in some situations. More investigation needs to be done but for now let's revert it.

Modification:

Revert commit 4e1a0c3

Result:

No more race which cause multiple RST frames to be send for the same stream id.

codec-http2/src/main/java/io/netty5/handler/codec/http2/DefaultHttp2Connection.java

@@ -738,16 +738,13 @@ public boolean canOpenStream() {
         public DefaultStream createStream(int streamId, boolean halfClosed) throws Http2Exception {
             State state = activeState(streamId, IDLE, isLocal(), halfClosed);
 
-            try {
-                checkNewStreamAllowed(streamId, state);
-            } finally {
-                // Always increment Expected stream ID
-                incrementExpectedStreamId(streamId);
-            }
+            checkNewStreamAllowed(streamId, state);
 
             // Create and initialize the stream.
             DefaultStream stream = new DefaultStream(streamId, state);
 
+            incrementExpectedStreamId(streamId);
+
             addStream(stream);
 
             stream.activate();

codec-http2/src/test/java/io/netty5/handler/codec/http2/DefaultHttp2ConnectionTest.java

@@ -347,21 +347,6 @@ public void clientLocalIncrementAndGetStreamShouldRespectOverflow() throws Http2
         incrementAndGetStreamShouldRespectOverflow(client.local(), MAX_VALUE);
     }
 
-    @Test
-    public void incrementAndGetStreamShouldAlwaysIncrement() {
-        final int streamId = client.local().lastStreamKnownByPeer() + 1;
-
-        assertThrows(Http2Exception.class, new Executable() {
-            @Override
-            public void execute() throws Throwable {
-                client.local().createStream(streamId, true);
-            }
-        });
-
-        int nextStreamID = client.local().incrementAndGetNextStreamId();
-        assertEquals(streamId, nextStreamID - 3);
-    }
-
     @Test
     public void clientLocalCreateStreamExhaustedSpace() throws Http2Exception {
         client.local().createStream(MAX_VALUE, true);