Skip to content

Commit

Permalink
Skip revapi checks for testsuite modules (#13258)
Browse files Browse the repository at this point in the history
Motivation:

We should skip revapi checks for testsuite modules as these are not expected to be public API

Modifications:

Add configuration for skipping

Result:

No API check for testsuites
  • Loading branch information
normanmaurer committed Mar 2, 2023
1 parent 971aa8a commit 99204e9
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions testsuite-autobahn/pom.xml
Expand Up @@ -30,6 +30,7 @@

<properties>
<japicmp.skip>true</japicmp.skip>
<revapi.skip>true</revapi.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty.testsuite_autobahn</javaModuleName>
Expand Down
1 change: 1 addition & 0 deletions testsuite-http2/pom.xml
Expand Up @@ -30,6 +30,7 @@

<properties>
<japicmp.skip>true</japicmp.skip>
<revapi.skip>true</revapi.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty.testsuite_http2</javaModuleName>
Expand Down
1 change: 1 addition & 0 deletions testsuite-native-image-client-runtime-init/pom.xml
Expand Up @@ -30,6 +30,7 @@

<properties>
<japicmp.skip>true</japicmp.skip>
<revapi.skip>true</revapi.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty.testsuite_native_image_client_runtime_init</javaModuleName>
Expand Down
1 change: 1 addition & 0 deletions testsuite-native-image-client/pom.xml
Expand Up @@ -30,6 +30,7 @@

<properties>
<japicmp.skip>true</japicmp.skip>
<revapi.skip>true</revapi.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty.testsuite_native_image_client</javaModuleName>
Expand Down
1 change: 1 addition & 0 deletions testsuite-native-image/pom.xml
Expand Up @@ -30,6 +30,7 @@

<properties>
<japicmp.skip>true</japicmp.skip>
<revapi.skip>true</revapi.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty.testsuite_native_image</javaModuleName>
Expand Down
1 change: 1 addition & 0 deletions testsuite-native/pom.xml
Expand Up @@ -30,6 +30,7 @@

<properties>
<japicmp.skip>true</japicmp.skip>
<revapi.skip>true</revapi.skip>
<skipNativeTestsuite>false</skipNativeTestsuite>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
Expand Down
1 change: 1 addition & 0 deletions testsuite-osgi/pom.xml
Expand Up @@ -32,6 +32,7 @@
<exam.version>4.13.0</exam.version>
<argLine.java9.extras>--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.security=ALL-UNNAMED</argLine.java9.extras>
<japicmp.skip>true</japicmp.skip>
<revapi.skip>true</revapi.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty.testsuite_osgi</javaModuleName>
Expand Down
1 change: 1 addition & 0 deletions testsuite-shading/pom.xml
Expand Up @@ -40,6 +40,7 @@
<skipShadingTestsuite>true</skipShadingTestsuite>
<shadedPackagePrefix>io.netty.</shadedPackagePrefix>
<japicmp.skip>true</japicmp.skip>
<revapi.skip>true</revapi.skip>
<!-- Do not deploy this module -->
<skipDeploy>true</skipDeploy>
<javaModuleName>io.netty.testsuite_shading</javaModuleName>
Expand Down
1 change: 1 addition & 0 deletions testsuite/pom.xml
Expand Up @@ -120,6 +120,7 @@
<!-- Needed for SSL tests as these use the SelfSignedCertificate -->
<argLine.java9.extras>--add-exports java.base/sun.security.x509=ALL-UNNAMED</argLine.java9.extras>
<japicmp.skip>true</japicmp.skip>
<revapi.skip>true</revapi.skip>
<javaModuleName>io.netty.testsuite</javaModuleName>
</properties>

Expand Down

0 comments on commit 99204e9

Please sign in to comment.