Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added type definition to generateInspectSettings #6422

Closed

Conversation

HannahThor
Copy link
Contributor

@HannahThor HannahThor commented Mar 8, 2024

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

This is my first open source PR and I just wanted to help remove some of the ts-expect-error from the CLI. There's plenty of other types that need defining in this file, but I just wanted to start small!


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)
image

@HannahThor HannahThor requested a review from a team as a code owner March 8, 2024 11:28
Copy link
Contributor

@khendrikse khendrikse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @HannahThor thank you so much for contributing! This looks really good, let's get this thing merged.

Copy link

github-actions bot commented Mar 11, 2024

πŸ“Š Benchmark results

Comparing with 2a2de3f

  • Dependency count: 1,326 (no change)
  • Package size: 298 MB (no change)
  • Number of ts-expect-error directives: 1,111 ⬇️ 0.09% decrease vs. 2a2de3f

@lemusthelroy lemusthelroy enabled auto-merge (squash) March 20, 2024 11:24
@lemusthelroy
Copy link
Contributor

It looks like another PR was merged that did the same type conversion. Sorry we couldn't get this merged.

On a positive note, this has helped to identify a flakey test which we intend to fix. See PR

auto-merge was automatically disabled April 2, 2024 10:14

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants