Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure tests requiring netlify account are skipped #6487

Conversation

lemusthelroy
Copy link
Contributor

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

Some tests from external contributors were failing where an account is required.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@lemusthelroy lemusthelroy requested a review from a team as a code owner April 2, 2024 10:12
Copy link

github-actions bot commented Apr 2, 2024

πŸ“Š Benchmark results

Comparing with 9b30807

  • Dependency count: 1,313 (no change)
  • Package size: 294 MB ⬆️ 0.00% increase vs. 9b30807
  • Number of ts-expect-error directives: 1,008 (no change)

@lemusthelroy lemusthelroy enabled auto-merge (squash) April 9, 2024 12:16
@lemusthelroy lemusthelroy merged commit 5f561c6 into main Apr 9, 2024
40 checks passed
@lemusthelroy lemusthelroy deleted the lemusthelroy/ct-830-some-cli-integration-tests-fail-on-prs-from-forked-repos branch April 9, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants