fix(command-dev): optionally pass settings to getNetlifyGraphConfig #4132
+8
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When starting
netlify dev --graph
in a new remix project, I would run into:Turns out this happens because
getNetlifyGraphConfig
runs after thedev
command has already started a server on port 3000 and then use
detectServerSettings
which includes a call to
acquirePort
and cause the startup to fail.This makes sure that
detectServerSettings
only runs one duringnetlify dev