fix(command-dev): optionally pass settings to getNetlifyGraphConfig (#4132)

This prevents an issue where the detectServerSettings calls acquirePort twice
and ends up blowing up by making sure we only run the detection once within
netlify dev

Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>

Author: biilmann

src/commands/dev/dev.js

@@ -308,7 +308,7 @@ const dev = async (options, command) => {
   } else if (startNetlifyGraphWatcher) {
     const netlifyToken = await command.authenticate()
     await OneGraphCliClient.ensureAppForSite(netlifyToken, site.id)
-    const netlifyGraphConfig = await getNetlifyGraphConfig({ command, options })
+    const netlifyGraphConfig = await getNetlifyGraphConfig({ command, options, settings })
 
     log(`Starting Netlify Graph session, to edit your library run \`netlify graph:edit\` in another tab`)
 

src/lib/one-graph/cli-netlify-graph.js

@@ -29,7 +29,7 @@ const filterRelativePathItems = (items) => items.filter((part) => part !== '')
  * @param {import('../base-command').BaseCommand} command
  * @return {NetlifyGraphConfig} NetlifyGraphConfig
  */
-const getNetlifyGraphConfig = async ({ command, options }) => {
+const getNetlifyGraphConfig = async ({ command, options, settings }) => {
   const { config, site } = command.netlify
   config.dev = { ...config.dev }
   config.build = { ...config.build }
@@ -44,11 +44,12 @@ const getNetlifyGraphConfig = async ({ command, options }) => {
   }
 
   /** @type {Partial<import('../../utils/types').ServerSettings>} */
-  let settings = {}
-  try {
-    settings = await detectServerSettings(devConfig, options, site.root)
-  } catch (detectServerSettingsError) {
-    error(detectServerSettingsError)
+  if (!settings) {
+    try {
+      settings = await detectServerSettings(devConfig, options, site.root)
+    } catch (detectServerSettingsError) {
+      error(detectServerSettingsError)
+    }
   }
 
   const siteRoot = [path.sep, ...filterRelativePathItems(site.root.split(path.sep))]