Fix selfRequired: false
not making an object-type property optional
#3347
+61
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
When using
@ApiProperty({ type: 'object', selfRequired: false })
on an object (which is enforced by types,required: false
cannot be used on an object as it refers to its own properties), the property is added to the list ofrequired
properties. This is a bug.What is the new behavior?
Setting
selfRequired: false
on a object-type property does work, and the property is not added to the list ofrequired
. This is implemented by havingselfRequired
taking precedence overrequired
, asselfRequired
is non-ambiguous about its intent (it can only be used for object types, with the clear meaning of applying to the decorated property).Does this PR introduce a breaking change?
Other information
Related to #3163.