-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): middleware is not executed for root route when global prefix is set #13337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit edd5eaf.
…yTseng/nest into CodyTseng-fix-global-prefix-middleware
This was referenced Mar 18, 2024
Pull Request Test Coverage Report for Build 7adabfa0-ed39-40ba-9e86-028b02c6c50fDetails
💛 - Coveralls |
I'll have to check this myself, but I already heard from two of our users that this is not fixing the actual problem, at least not for the MikroORM integration. |
15 tasks
This is still not working for our apps even with latest version of nest (10.3.8), particularly with the MikroORM integration |
Could you please provide a minimum reproduction repository @eric-deeporigin? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #11572
What is the new behavior?
Based off #12179
Does this PR introduce a breaking change?
Other information