Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement getHeader and appendHeader methods in adapters #12955

Merged
merged 4 commits into from
Feb 7, 2024
Merged

feat: Implement getHeader and appendHeader methods in adapters #12955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfd0ab6
feat: Implement getHeader and appendHeader methods in adapters
josesilveiraa07 Dec 20, 2023
5c78423
fix: Wrong getHeader method signature
josesilveiraa07 Dec 20, 2023
9a1a776
fix: Wrong getHeader method signature in http-adapter class
josesilveiraa07 Dec 20, 2023
36411c3
fix: Implement AbstractHttpAdapter in NoopHttpAdapter
josesilveiraa07 Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/core/adapters/http-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,11 @@ export abstract class AbstractHttpAdapter<
abstract setErrorHandler(handler: Function, prefix?: string);
abstract setNotFoundHandler(handler: Function, prefix?: string);
abstract isHeadersSent(response: any);
// TODO remove optional signature (v11)
abstract getHeader?(response: any, name: string);
abstract setHeader(response: any, name: string, value: string);
// TODO remove optional signature (v11)
abstract appendHeader?(response: any, name: string, value: string);
abstract registerParserMiddleware(prefix?: string, rawBody?: boolean);
abstract enableCors(
options: CorsOptions | CorsOptionsDelegate<TRequest>,
Expand Down
2 changes: 2 additions & 0 deletions packages/core/test/utils/noop-adapter.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ export class NoopHttpAdapter extends AbstractHttpAdapter {
setErrorHandler(handler: Function, prefix = '/'): any {}
setNotFoundHandler(handler: Function, prefix = '/'): any {}
isHeadersSent(response: any): any {}
getHeader?(response: any, name: string) {}
setHeader(response: any, name: string, value: string): any {}
appendHeader?(response: any, name: string, value: string) {}
registerParserMiddleware(): any {}
enableCors(options: any): any {}
createMiddlewareFactory(requestMethod: RequestMethod): any {}
Expand Down
8 changes: 8 additions & 0 deletions packages/platform-express/adapters/express-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,18 @@ export class ExpressAdapter extends AbstractHttpAdapter<
return response.headersSent;
}

public getHeader?(response: any, name: string) {
return response.get(name);
}

public setHeader(response: any, name: string, value: string) {
return response.set(name, value);
}

public appendHeader?(response: any, name: string, value: string) {
return response.append(name, value);
}

public listen(port: string | number, callback?: () => void): Server;
public listen(
port: string | number,
Expand Down
8 changes: 8 additions & 0 deletions packages/platform-fastify/adapters/fastify-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,10 +466,18 @@ export class FastifyAdapter<
return response.sent;
}

public getHeader?(response: any, name: string) {
return response.getHeader(name);
}

public setHeader(response: TReply, name: string, value: string) {
return response.header(name, value);
}

public appendHeader?(response: any, name: string, value: string) {
response.header(name, value);
}

public getRequestHostname(request: TRequest): string {
return request.hostname;
}
Expand Down