fix(express): remove body-parser types and ship these types our own #11325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #11302
We were depending on
@types/body-parser
in this new feature, asbody-parser
does not ship its own types. But this breaks when usingskipLibsCheck: false
intsconfig.json
.What is the new behavior?
I moved the
@types/body-parser
interface we use over to@nestjs/platform-express
. We already have our ownNestExpressBodyParserOptions
which we can use to type ourselves. So this should not be a breaking change.Does this PR introduce a breaking change?
Other information