Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(graphql/lib): definitions generator defaultTypeMapping type reinforcement #3346

Merged

Conversation

Neosoulink
Copy link
Contributor

@Neosoulink Neosoulink commented Oct 24, 2024

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #3210

What is the new behavior?

Reinforce the DefinitionsGeneratorOptions.defaultTypeMapping interface for better visual over the allowed types.

Better suggestions over the supported types

Screenshot 2024-10-24 at 11 39 58 PM

Screenshot 2024-10-24 at 11 41 07 PM

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

will close #3210

Sorry, something went wrong.

### Description

- Reinforce the `DefinitionsGeneratorOptions.defaultTypeMapping` for better visual over allowed types
@kamilmysliwiec
Copy link
Member

LGTM

@kamilmysliwiec kamilmysliwiec merged commit f273dee into nestjs:master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat | clarifying DefinitionsGeneratorOptions#defaultTypeMapping supported types
2 participants