Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix macos proxy issue in development env #4205

Merged
merged 1 commit into from
Oct 27, 2023
Merged

chore: Fix macos proxy issue in development env #4205

merged 1 commit into from
Oct 27, 2023

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Oct 26, 2023 •
edited

What problem does this PR solve?

make test and make intergration on MacOs will fail because of 28631e1,
in that commit we updated reqwest to the latest version, which contains a commit to respect MacOS proxy settings.

It's inconvenient for devs who use vpn most of the time, and there is no feature option for it, so let's don't use the latest version right now.

Problem Summary:

What is changed and how it works?

Lock reqwest to version 0.11.20

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Release note 

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner October 26, 2023 09:32
@chenyukang chenyukang requested review from doitian and removed request for a team October 26, 2023 09:32
@zhangsoledad zhangsoledad added this pull request to the merge queue Oct 27, 2023
Merged via the queue into nervosnetwork:develop with commit 73ddfbf Oct 27, 2023
35 checks passed
eval-exec added a commit to nervosnetwork/ckb-cli that referenced this pull request Mar 7, 2024
@eval-exec
Pin reqwest to 0.11.20 because nervosnetwork/ckb#4205
0245a41
@eval-exec eval-exec mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@eval-exec eval-exec eval-exec approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chenyukang @zhangsoledad @eval-exec