Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(labeler): disable sync that interferes with other jobs #17409

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

dundargoc
Copy link
Member

@dundargoc dundargoc commented Feb 14, 2022

@github-actions github-actions bot added the ci automation for build, test, and release label Feb 14, 2022
@gpanders
Copy link
Member

Wouldn't a better temporary workaround be to just use the fork from actions/labeler#113?

-    - uses: actions/labeler@main
+    # Temporarily use a fork until https://github.com/actions/labeler/pull/113 is merged
+    - uses: epuertat/labeler@patch-2

Just my drive-by opinion. Feel free to ignore.

@dundargoc
Copy link
Member Author

Wouldn't a better temporary workaround be to just use the fork from actions/labeler#113?

-    - uses: actions/labeler@main
+    # Temporarily use a fork until https://github.com/actions/labeler/pull/113 is merged
+    - uses: epuertat/labeler@patch-2

Just my drive-by opinion. Feel free to ignore.

hmm, not totally against the idea but the branch is a 80 commit behind or so. Don't think it'd make much difference on the other hand.

@gpanders
Copy link
Member

hmm, not totally against the idea but the branch is a 80 commit behind or so. Don't think it'd make much difference on the other hand.

Good point, if we did go that route we would probably want to fork it ourselves and cherry-pick the relevant commit.

Might be more trouble than it's worth. Like I said, just a drive by opinion :)

@jamessan jamessan merged commit e29ba98 into neovim:master Feb 15, 2022
@dundargoc dundargoc deleted the ci/disable-sync branch February 15, 2022 11:25
@dundargoc dundargoc removed the request for review from jamessan November 7, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci automation for build, test, and release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants