Skip to content

Commit

Permalink
TASK: Revert type ignore hack for XMLReader and phpstan
Browse files Browse the repository at this point in the history
As the issue is fixed: phpstan/phpstan#8629
  • Loading branch information
mhsdesign committed Jan 24, 2024
1 parent 984971c commit b0534ef
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions Neos.Flow/Classes/I18n/Xliff/Service/XliffReader.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ public function readFiles($sourcePath, callable $iterator)
$reader->open($sourcePath);
$reader->read();

/** @phpstan-ignore-next-line the stubs for XMLReader are wrong https://github.com/phpstan/phpstan/issues/8629 */
if ($reader->nodeType == \XMLReader::ELEMENT && $reader->name === 'xliff') {
$version = $reader->getAttribute('version');
$result = true;
Expand Down Expand Up @@ -67,7 +66,6 @@ public function readFiles($sourcePath, callable $iterator)
*/
protected function isFileNode(\XMLReader $reader)
{
/** @phpstan-ignore-next-line the stubs for XMLReader are wrong https://github.com/phpstan/phpstan/issues/8629 */
return $reader->nodeType === \XMLReader::ELEMENT && $reader->name === 'file';
}
}

0 comments on commit b0534ef

Please sign in to comment.