Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove webpki #5069

Merged
merged 1 commit into from
Aug 30, 2023
Merged

chore: remove webpki #5069

merged 1 commit into from
Aug 30, 2023

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Aug 22, 2023

Problem

webpki is unmaintained

Closes https://github.com/neondatabase/neon/security/dependabot/33

Summary of changes

Update all dependents of webpki.

TODO: update sentry when getsentry/sentry-rust#593 gets released

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@github-actions
Copy link

github-actions bot commented Aug 22, 2023

1624 tests run: 1548 passed, 0 failed, 76 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_delete_timeline_client_hangup: debug
The comment gets automatically updated with the latest test results
0c75780 at 2023-08-30T13:57:36.885Z :recycle:

@arpad-m
Copy link
Member

arpad-m commented Aug 22, 2023

IMO it should be fine to use sentry from git for a while until the release is out.

@conradludgate conradludgate force-pushed the remove-webpki branch 2 times, most recently from b86a7e3 to f27d260 Compare August 25, 2023 12:31
@conradludgate conradludgate marked this pull request as ready for review August 25, 2023 14:51
@conradludgate conradludgate requested a review from a team as a code owner August 25, 2023 14:51
@conradludgate conradludgate requested review from nikitakalyanov and removed request for a team August 25, 2023 14:51
Copy link
Contributor

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite few updates. Could we hold off merging until the release for the aws-sdk upgrades?

@koivunej
Copy link
Contributor

Good to merge.

Cargo.toml Outdated Show resolved Hide resolved
@conradludgate conradludgate requested a review from a team as a code owner August 30, 2023 12:29
@conradludgate conradludgate merged commit 3b81e0c into main Aug 30, 2023
33 checks passed
@conradludgate conradludgate deleted the remove-webpki branch August 30, 2023 14:14
bayandin added a commit that referenced this pull request Sep 29, 2023
## Problem

I've noticed that `hermit-abi`
0.3.1 [1] has been yanked from crates.io (looks like nothing too
bad [2]).
Also, we have 2 versions of `hermit-api` in dependencies (0.3.* and
0.2.*), update `num-cpus` to use the latest `hermit-api` 0.3.3.

- [1] https://crates.io/crates/hermit-abi/0.3.1
- [2] hermit-os/hermit-rs#436

## Summary of changes
- `cargo update -p num-cpus`
- `cargo update -p hermit-abi`
- Unignore `RUSTSEC-2023-0052` in `deny.toml` (it has been fixed in
#5069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants