Introduce home database resolution cache #1600
Merged
+2,113
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/home-database
branch
2 times, most recently
from
9654cdb to
543e2d4
Compare
injectives
force-pushed
the
feature/home-database
branch
from
10a5e09 to
e6e878d
Compare
injectives
changed the title
injectives
force-pushed
the
feature/home-database
branch
2 times, most recently
from
813583d to
8471f76
Compare
This update adds support for Bolt protocol 5.8 and introduces home database resolution cache that works with Bolt protocol 5.8+ when routing scheme is used. The cache is maintained by the driver internally and is not exposed in the API, its purpose is to reduce the number of Bolt exchanges when home database resolution is needed.
injectives
force-pushed
the
feature/home-database
branch
from
8471f76 to
6516dbc
Compare
| @@ -208,4 +208,12 @@ public boolean isRoutingTableAged() { | |||
| public RoutingTable routingTable() { | |||
| return routingTable; | |||
| } | |||
|
|
|||
| @Override | |||
| public synchronized boolean staleRoutingTable(AccessMode mode) { | |||
There was a problem hiding this comment.
Would isRoutingTableStale be more fitting?
driver/src/main/java/org/neo4j/driver/internal/homedb/HomeDatabaseCacheImpl.java
Show resolved
Hide resolved
driver/src/main/java/org/neo4j/driver/internal/homedb/HomeDatabaseCacheKey.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds support for Bolt protocol 5.8 and introduces home database resolution cache that works with Bolt protocol 5.8+ when routing scheme is used. The cache is maintained by the driver internally and is not exposed in the API, its purpose is to reduce the number of Bolt exchanges when home database resolution is needed.