Skip to content

Commit

Permalink
possible fix for cache pools and different areas
Browse files Browse the repository at this point in the history
  • Loading branch information
Adrian Brajkovic committed Mar 4, 2024
1 parent b306289 commit 24edba5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/DependencyInjection/NelmioApiDocExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public function load(array $configs, ContainerBuilder $container): void
->setPublic(false);

$cachePool = isset($config['cache']['pool']) ? new Reference($config['cache']['pool']) : null;
$cacheItemId = $config['cache']['item_id'] ?? null;
$cacheItemId = $config['cache']['item_id'] ?? 'openapi_doc';

foreach ($config['areas'] as $area => $areaConfig) {
$nameAliases = $this->findNameAliases($config['models']['names'], $area);
Expand All @@ -100,7 +100,7 @@ public function load(array $configs, ContainerBuilder $container): void
new TaggedIteratorArgument(sprintf('nelmio_api_doc.describer.%s', $area)),
new TaggedIteratorArgument('nelmio_api_doc.model_describer'),
$cachePool,
$cacheItemId,
$cacheItemId.'.'.$area,
new Reference('nelmio_api_doc.open_api.generator'),
]);

Expand Down
4 changes: 2 additions & 2 deletions tests/DependencyInjection/NelmioApiDocExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,9 @@ public function testApiDocGeneratorWithCachePool()
$this->assertSame('test.cache', (string) $reference);

$cacheItemId = $container->getDefinition('nelmio_api_doc.generator.default')->getArgument(3);
$this->assertSame('nelmio.docs', $cacheItemId);
$this->assertSame('nelmio.docs.default', $cacheItemId);

$cacheItemId = $container->getDefinition('nelmio_api_doc.generator.area1')->getArgument(3);
$this->assertSame('nelmio.docs', $cacheItemId);
$this->assertSame('nelmio.docs.area1', $cacheItemId);
}
}

0 comments on commit 24edba5

Please sign in to comment.