P1: [Darkside] Primitives spacing -> space migrations #3597
+804
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6d19a42 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demo / Chromatic📝 Changes to review: 11b7d26ddb | 91 components | 135 stories |
it-vegard
reviewed
Feb 19, 2025
@navikt/aksel/src/codemod/transforms/darkside/primitives-spacing/spacing.ts
Outdated
Show resolved
Hide resolved
* ✨ Added migration for css, less and scsss * Update @navikt/aksel/src/codemod/migrations.ts
KenAJoh
changed the title
Comment on lines
+37
to
+46
|
|
||
| path.node.specifiers.forEach((specifier) => { | ||
| if ( | ||
| specifier.type === "ImportSpecifier" && | ||
| specifier.imported.name === name | ||
| ) { | ||
| foundName = specifier.local | ||
| ? specifier.local.name | ||
| : specifier.imported.name; | ||
| } |
There was a problem hiding this comment.
I don't know if we already discussed this, and I am not even sure i want it, but just in case we do --> should we add an option for default imports?
Suggested change
| path.node.specifiers.forEach((specifier) => { | |
| if ( | |
| specifier.type === "ImportSpecifier" && | |
| specifier.imported.name === name | |
| ) { | |
| foundName = specifier.local | |
| ? specifier.local.name | |
| : specifier.imported.name; | |
| } | |
| // Check for named imports | |
| path.node.specifiers.forEach((specifier) => { | |
| if ( | |
| specifier.type === "ImportSpecifier" && | |
| specifier.imported.name === name | |
| ) { | |
| foundName = specifier.local | |
| ? specifier.local.name | |
| : specifier.imported.name; | |
| } | |
| // Check for default imports. i.e.: | |
| // import Box from "@navikt/ds-react/Box" | |
| if ( | |
| specifier.type === "ImportDefaultSpecifier" && | |
| typeof path.node.source.value === "string" && | |
| path.node.source.value.endsWith(`/${name}`) | |
| ) { | |
| foundName = specifier.local.name; | |
| } |
There was a problem hiding this comment.
Haven't really found any cases where this is used, but could make sense just in case. If we add this, we will need to handle the name differently since
import * as Box from "@navikt/ds-react/Box`
leads to components being used like
<Box.Box>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the start of various migrations for new tokens.
space-tokenNext up will be CSS, SCSS, Less and JS token migrations from a-spacing -> a-space.
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")