Ny komponent FileUpload #2504
Merged
Ny komponent FileUpload #2504
+2,723
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7fb62b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 790d6aca34 | 60 komponenter | 225 stories |
Og leggg på dragover-effekt
Usikker på om dette er foretrukket over slik det var, men verdt et forsøk for diskusjonens skyld.
torkjels
commented
Nov 22, 2023
Etter prat med Vegard fant vi ut at det var hakket mer semantisk korrekt (og gap er litt penere enn egen klasse med margin)
torkjels
force-pushed
the
file-uploader
branch
from
44ee5ab to
6cb8990
Compare
torkjels
force-pushed
the
file-uploader
branch
from
6cb8990 to
df47411
Compare
Måtte da flytte labelet litt lenger inn og heller legge stylinga på et element lenger ut, men det løste seg.
Så lenge parent ikke har en mindre width enn det som her blir minWidth vil vi ikke få overflow. Er dette for en for yolo løsning?
KenAJoh
reviewed
Nov 24, 2023
KenAJoh
reviewed
Nov 24, 2023
torkjels
force-pushed
the
file-uploader
branch
3 times, most recently
from
a6163c4 to
4ffc818
Compare
torkjels
force-pushed
the
file-uploader
branch
from
4ffc818 to
d1f6101
Compare
HalvorHaugan
removed
the
ignore-chromatic
@navikt/core/react/src/form/file-upload/parts/dropzone/dropzone.types.ts
Outdated
Show resolved
Hide resolved
KenAJoh
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
De siste endringene så bra ut de! Da tror jeg ikke det er så mye mer som gir mening å teste hos oss før vi slipper den og lar alle andre teste den da 🚀 🚀 💯
Note for fremtiden.: Istedenfor å måtte ha contexter som dette: https://github.com/navikt/aksel/pull/2504/files#diff-ac4a6d8d97aaab6c44760b05e5e32a49f446a6c5952470cae310e2c357090cebR129
vil det kanskje gi mening å ha en egen TranslationProvider vi kan bruke internt i systemet.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ny komponent FileUpload 🎉 🎉 🎉