Use readKeyFile to read both seed file and public key file #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5373303424
💛 - Coveralls |
Fixed |
It's consistent with the key reading behavior in `sign`, and we can add some comments in both seed file and public key file. And encode the signature with base64 url nopadding format instead of base64 std, since jwt signature is using base64 url nopadding format. So that `nk` command can be used to verify jwt token conviniently. Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
| @@ -157,7 +157,7 @@ func sign(fname, keyFile string) { | |||
| if err != nil { | |||
| log.Fatal(err) | |||
| } | |||
| log.Printf("%s", base64.StdEncoding.EncodeToString(sigraw)) | |||
| log.Printf("%s", base64.RawURLEncoding.EncodeToString(sigraw)) | |||
There was a problem hiding this comment.
Because in JWT three parts, header.payload.signature, the signature part is encoded in base64 url no padding format according JWT spec. If nk uses base64 url no padding format as signature content, nk command can be used to verify jwt token like this:
nk -verify header.payload -pubin pubin -sigfile signature
Or nk would compain illegle charset error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's consistent with the key reading behavior in
sign, and we can add some comments in both seed file and public key file.