Match replies to request in nats sub
#542
Conversation
There was a problem hiding this comment.
Nice idea I like it but probably it will be for the next CLI release so I will land a few PRs today and then we rebase and review this one thoroughly for the next release.
The print logic has been a area of many bugs so I want to be quite careful when toushing this
Sorry for the delay here I was out for a few weeks
Haramaty
force-pushed
the
feature/match-replies
branch
from
02be17a to
834a94d
Compare
|
Hi, thank you for the PR 😊 Sorry about all the name conventions, I haven't written Go in some years. Let me know when you're reviewing this again, or if you need me to rebase again 👍🏼 |
|
nice, thanks for the update, I will test it during the week carefully and let you know! nice idea thank you |
When `--match-replies` flag is given, requests are matched with their respective replies, and printed/dumped together (respecting `--dump`/`--raw` flags). This is implemented by listening to all subjects under `_INBOX`, and matching them with requests using a map. Co-authored-by: Margarita Tronik <mtronik1@gmail.com>
Haramaty
force-pushed
the
feature/match-replies
branch
from
834a94d to
3451ca0
Compare
|
I forgot to run |
|
Thanks for the contribution! |
This adds a
--match-repliesflag tonats subwhich matches replies to any request sent to the subscribed subject.The feature is implemented using an additional subscription on
_INBOX.>subject, and a map matching reply subjects to requests.