Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Drain() infinite loop and add test for concurrent Next() calls #1525

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Fix Drain() infinite loop and add test for concurrent Next() calls #1525

merged 6 commits into from
Jan 15, 2024

Commits on Jan 14, 2024

  1. Added failing graceful shutdown test for MessagesContext.Drain method

    @mdawar
    mdawar committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    284a639 View commit details
    Browse the repository at this point in the history

  2. Minimize lock scope in pullSubscription.Next to allow for cleanup 

    Fixes possible deadlock when Next() is waiting and holding the lock and
cleanup() waiting for the lock to unsubscribe.
    @mdawar
    mdawar committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    0976e9b View commit details
    Browse the repository at this point in the history

  3. Remove unused drained channel from pullSubscription

    @mdawar
    mdawar committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    8ec5423 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Added test for auto unsubscribe with concurrent calls

    @mdawar
    mdawar committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    10bee37 View commit details
    Browse the repository at this point in the history

  2. Revert locking in Next and remove cleanup lock

    @mdawar
    mdawar committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    0460e1a View commit details
    Browse the repository at this point in the history

  3. Prevent hanging in the auto-unsubscribe test 

    Added comment for the cleanup function on why it doesn't need to hold
the lock.
    @mdawar
    mdawar committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    a482cc6 View commit details
    Browse the repository at this point in the history