Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry picks for Release v2.10.11 #5074

Merged
merged 21 commits into from
Feb 14, 2024
Merged

Conversation

wallyqs and others added 18 commits February 13, 2024 11:45
Signed-off-by: Waldemar Quevedo <wally@nats.io>
…th violation error was not sent to the client, thus the client would simply timeout.
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
…a-leader.

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
- Cleaned up the retained message consumer name so that it does not
cause problems
- Per @derekcollison's recommendation, use an ephemeral consumer for
retained messages
Do not force sequence mismatches and possible dataloss on first sequence
move past a catchup request.

When a server restarts and does a stream catchup where the snapshot from
the leader is for messages it no longer has, we would create a sequence
mismatch reset on the follower.
    
Also on a catchup if the stream state has moved past the updated request
range from a follower, meaning first for the new state is past the last
of the request, extend and continue catchup.

Signed-off-by: Derek Collison <derek@nats.io>

---------

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
…tered mode. If not clustered only check in processJetStreamMsg.

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
…ax bytes set, we need to do those checks before proposing the message.

The reason is that the consumer ack flow will be async state and some replicas might accept the message where others would not based on limits.

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
This request was raised in #555 (2017) and more recently in the
nats-docker repo here: nats-io/nats-docker#117.

Signed-off-by: Byron Ruth <byron@nats.io>
…ynamic memory calculations for JetStream.

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
@wallyqs wallyqs marked this pull request as ready for review February 13, 2024 21:25
@wallyqs wallyqs requested a review from a team as a code owner February 13, 2024 21:25
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

derekcollison and others added 2 commits February 13, 2024 15:54
…der filtered subject.

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 8fd0530 into release/v2.10.11 Feb 14, 2024
4 checks passed
@wallyqs wallyqs deleted the downstream/v2.10.11 branch February 14, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants