Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick PRs into v2.10.8 release branch #4931

Merged
merged 11 commits into from
Jan 9, 2024

Conversation

dependabot bot and others added 9 commits January 9, 2024 15:19
Bumps [github.com/nats-io/nkeys](https://github.com/nats-io/nkeys) from 0.4.6 to 0.4.7.
- [Release notes](https://github.com/nats-io/nkeys/releases)
- [Changelog](https://github.com/nats-io/nkeys/blob/main/.goreleaser.yml)
- [Commits](nats-io/nkeys@v0.4.6...v0.4.7)

---
updated-dependencies:
- dependency-name: github.com/nats-io/nkeys
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Phil Pennock <pdp@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.15.0 to 0.16.0.
- [Commits](golang/sys@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Under scenarios where interior deletes were orders of magnitudes larger than the msgs themselves, the system would need to transfer all interior deletes as skip msgs.
This change adopts the ability to send DeleteRanges on streamSyncRequests, and for R1 mirrors to locally use the new store.SkipMsgs to optimize speed.

This CL also has a bug fix for memory store state with delete details, and several general improvements to the filestore impl.

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner January 9, 2024 15:21
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

derekcollison and others added 2 commits January 9, 2024 20:27
… routes/gateways. (#4933)

Avoid needing the lock for mset subscriptions to avoid possibly blocking
routes/gateways.
Also increase timeout for consumer creation for sources since might take
a bit longer.

 Signed-off-by: Derek Collison <derek@nats.io>

---------

Signed-off-by: Derek Collison <derek@nats.io>
…4835)

Speed up sending out retained messages to a sub by loading them from
JetStream concurrently.

- added `jsa.newRequestExMulti` that fans out multiple requests (on the
same subject, at least for now) and gathers all responses
- further changed the processing of retained messages in
`as.processSubs`: now we
- a) find all messages that we need and that are not in `rmsCache` first
  - (b) load them to `rms` with one call
- (c) serialize to subs/filters and fail the filter if it misses
messages from (a) in `rms`.

---------

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Co-authored-by: Ivan Kozlovic <ivan@synadia.com>
@wallyqs wallyqs merged commit 46c2807 into release/v2.10.8 Jan 9, 2024
4 checks passed
@wallyqs wallyqs deleted the neil/2108cherrypick branch January 9, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants