Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick PRs into v2.10.8 release branch #4912

Merged
merged 5 commits into from
Dec 26, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Dec 26, 2023

neilalexander and others added 5 commits December 26, 2023 09:29
Signed-off-by: Neil Twigg <neil@nats.io>
Previously ' ' and '.' were not supported for MQTT topics until #4243 brought in support for '.'. However the error message for unsupported characters appears to not have been updated. This simply updates the error message.

Had an example of a MQTT client trying to publish to `spBv1.0/Field Devices/Some Device/Some Topic` and the error message indicated that both '.' and ' ' were unsupported which was misleading as only ' ' is unsupported.
Signed-off-by: Derek Collison <derek@nats.io>
…for account info for reserved storage.

Signed-off-by: Derek Collison <derek@nats.io>
…ount.

Signed-off-by: Derek Collison <derek@nats.io>
@wallyqs wallyqs requested a review from a team as a code owner December 26, 2023 17:31
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 4f0896d into release/v2.10.8 Dec 26, 2023
3 of 4 checks passed
@wallyqs wallyqs deleted the downstream/v2.10.8 branch December 26, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants