Fixes to /healthz response (v2.10) #4467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
wallyqs
force-pushed
the
healthz-mon-fixes
branch
from
40d22a7
to
1f2d56a
Compare
derekcollison
approved these changes
Sep 1, 2023
| @@ -2339,7 +2339,6 @@ func ResponseHandler(w http.ResponseWriter, r *http.Request, data []byte) { | |||
| func handleResponse(code int, w http.ResponseWriter, r *http.Request, data []byte) { | |||
| // Get callback from request | |||
| callback := r.URL.Query().Get("callback") | |||
| // If callback is not empty then | |||
| if callback != "" { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #4437 content-type fix for v2.9.22, some fixes to the response from
/healthzfor dev:status_codein the healthz response (e.g{"status":"ok","status_code":200}) so this removes it for http responses just relying on the http header.