Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Make sure to properly handle filtered purges with consumers that have a wider filtered subject. #5075

Merged
merged 1 commit into from Feb 13, 2024
Merged

[FIXED] Make sure to properly handle filtered purges with consumers that have a wider filtered subject. #5075

merged 1 commit into from Feb 13, 2024

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison derekcollison requested a review from a team as a code owner February 13, 2024 21:39
neilalexander
neilalexander approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in principle (but looks like a test is failing?)

@derekcollison
Make sure to properly handle filtered purge with a consumer with a wi…
32a96c7 
…der filtered subject.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison changed the title [FIXED] Make sure to properly set first and match for consumers that match all for filtered purge. [FIXED] Make sure to properly handle filtered purges with consumers that have a wider filtered subject. Feb 13, 2024
wallyqs
wallyqs approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

neilalexander
neilalexander approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derekcollison derekcollison merged commit d549b4a into main Feb 13, 2024
4 checks passed
@derekcollison derekcollison deleted the filtered-purge-nap branch February 13, 2024 23:51
@wallyqs wallyqs mentioned this pull request Feb 13, 2024
Merged
wallyqs added a commit that referenced this pull request Feb 14, 2024
@wallyqs
Cherry picks for Release v2.10.11 (#5074)
8fd0530 
- #5045
- #5038
- #5035
- #4821
- #5041
- #5048
- #5054
- #5056
- #5059
- #5058
- #5068
- #5073
- #5075
- #5076 
- #5077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derekcollison @wallyqs @neilalexander