Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Share higher fidelity client info with JetStream #5019

Merged
merged 2 commits into from Jan 31, 2024
Merged

[IMPROVED] Share higher fidelity client info with JetStream #5019

merged 2 commits into from Jan 31, 2024

Conversation

derekcollison
Copy link
Member

This was intent of original design but was only sharing basic info.

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Share higher fidelity client info with JetStream
c339c8d 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner January 31, 2024 20:46
ripienaar
ripienaar approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison
Copy link
Member Author

Once green will merge.

@derekcollison
Need this protection here as well since calling directly for JetStrea…
8e0e768 
…m setup

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison merged commit a80fb4d into main Jan 31, 2024
4 checks passed
@derekcollison derekcollison deleted the ci-share branch January 31, 2024 21:40
@wallyqs wallyqs mentioned this pull request Jan 31, 2024
Merged
wallyqs added a commit that referenced this pull request Feb 1, 2024
@wallyqs
Cherry-pick PRs into v2.10.10 release branch (#5020)
2f8be20 
Includes:

- #5013 
- #5017 
- #5019 
- #5022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripienaar ripienaar ripienaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derekcollison @ripienaar