[IMPROVED] Share higher fidelity client info with JetStream (#5019)

This was intent of original design but was only sharing basic info.

Signed-off-by: Derek Collison <derek@nats.io>

server/accounts.go

@@ -1877,6 +1877,10 @@ func (a *Account) addServiceImport(dest *Account, from, to string, claim *jwt.Im
 	rt := Singleton
 	var lat *serviceLatency
 
+	if dest == nil {
+		return nil, ErrMissingAccount
+	}
+
 	dest.mu.RLock()
 	se := dest.getServiceExport(to)
 	if se != nil {

server/jetstream.go

@@ -1,4 +1,4 @@
-// Copyright 2019-2023 The NATS Authors
+// Copyright 2019-2024 The NATS Authors
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
@@ -653,9 +653,14 @@ func (a *Account) enableAllJetStreamServiceImportsAndMappings() error {
 	}
 
 	if !a.serviceImportExists(jsAllAPI) {
-		if err := a.AddServiceImport(s.SystemAccount(), jsAllAPI, _EMPTY_); err != nil {
+		// Capture si so we can turn on implicit sharing with JetStream layer.
+		si, err := a.addServiceImport(s.SystemAccount(), jsAllAPI, _EMPTY_, nil)
+		if err != nil {
 			return fmt.Errorf("Error setting up jetstream service imports for account: %v", err)
 		}
+		a.mu.Lock()
+		si.share = true
+		a.mu.Unlock()
 	}
 
 	// Check if we have a Domain specified.

server/jetstream_events.go

@@ -18,7 +18,7 @@ import (
 	"time"
 )
 
-func (s *Server) publishAdvisory(acc *Account, subject string, adv interface{}) {
+func (s *Server) publishAdvisory(acc *Account, subject string, adv any) {
 	if acc == nil {
 		acc = s.SystemAccount()
 		if acc == nil {

server/jetstream_test.go

@@ -10631,8 +10631,14 @@ func TestJetStreamAccountImportJSAdvisoriesAsService(t *testing.T) {
 	gotEvents = map[string]int{}
 	for i := 0; i < 2; i++ {
 		msg, err := subAgg.NextMsg(time.Second * 2)
-		if err != nil {
-			t.Fatalf("Unexpected error: %v", err)
+		require_NoError(t, err)
+		var adv JSAPIAudit
+		require_NoError(t, json.Unmarshal(msg.Data, &adv))
+		// Make sure we have full fidelity info via implicit share.
+		if adv.Client != nil {
+			require_True(t, adv.Client.Host != _EMPTY_)
+			require_True(t, adv.Client.User != _EMPTY_)
+			require_True(t, adv.Client.Lang != _EMPTY_)
 		}
 		gotEvents[msg.Subject]++
 	}