[IMPROVED] Avoid stream locks for certain operations that could block routes/gateways. #4933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing routes/gateways. Also increase timeout for consumer creation for sources since might take a bit longer. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
…r responses in case stream leader not ready Signed-off-by: Derek Collison <derek@nats.io>
…checks Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
pushed a commit
that referenced
this pull request
Jan 9, 2024
… routes/gateways. (#4933) Avoid needing the lock for mset subscriptions to avoid possibly blocking routes/gateways. Also increase timeout for consumer creation for sources since might take a bit longer. Signed-off-by: Derek Collison <derek@nats.io> --------- Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid needing the lock for mset subscriptions to avoid possibly blocking routes/gateways.
Also increase timeout for consumer creation for sources since might take a bit longer.
Signed-off-by: Derek Collison derek@nats.io