Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make UvExecutor set directory and project options on uv run #285

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

nat-n
Copy link
Owner

@nat-n nat-n commented Mar 15, 2025

fixes #281

Description of changes

Replace this text with a description of the changes proposed in this PR, including the motivation for these changes and a reference to any related GitHub issue or discussion.

Pre-merge Checklist

  • Bug fixes (if any) are accompanied by a test (if not too complicated to do so)
  • poe check executed successfully
  • This PR targets the development branch for code changes or main if only documentation is updated

Sorry, something went wrong.

fixes #281

 #Please enter the commit message for your changes. Lines starting
@nat-n nat-n requested a review from Copilot March 15, 2025 20:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the UvExecutor to explicitly set the working directory and project directory by appending the appropriate options when executing uv commands. It also introduces updated configuration files and tests to validate that these options are correctly passed.

  • Added a subproject configuration for uv tasks.
  • Introduced a new test to validate working directory handling.
  • Updated the UvExecutor and base executor to resolve and use the working directory and project options.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/fixtures/uv_project/subproject/pyproject.toml Provides configuration for a uv subproject with the new uv-specific tool settings.
tests/test_uv_executor.py Adds a test to verify that the working directory and environment variables are correctly passed to uv tasks.
tests/fixtures/uv_project/pyproject.toml Updates the uv project configuration, including transforming the show-env task definition.
poethepoet/executor/uv.py Updates UvExecutor to append --directory and --project options based on resolved working directory and configuration.
pyproject.toml Adds .ruff_cache to the list of paths to be removed from generated files.
poethepoet/executor/base.py Resolves the working directory to an absolute path to ensure correctness in directory handling.

@nat-n nat-n merged commit 55e994c into development Mar 15, 2025
20 checks passed
@nat-n nat-n deleted the fix/281/uv_pwd branch March 15, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant