fix: The UV executor exectures the wrong file #283
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`uv` is installed via Snap on Ubuntu. Snap is a wrapper providing a safe environment for execution. Snap symlinks all executable commands to it's binary. * Called as `snap`: Snap CLI * Called as a symlink from any other file: Execute the file in it's environment The `UvExecutor` class resolved the path itself including any symlinks and eventually calls `/usr/bin/snap` instead of `/snap/bin/uv`. Snaps assumes a call to it's own CLI and fails. With this patch, the shell will resolve the path and provide the correct "executed file" information (`$0` in a Bash script) to Snap. fixes nat-n#282
nat-n
approved these changes
Mar 15, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 15, 2025
`uv` is installed via Snap on Ubuntu. Snap is a wrapper providing a safe environment for execution. Snap symlinks all executable commands to it's binary. * Called as `snap`: Snap CLI * Called as a symlink from any other file: Execute the file in it's environment The `UvExecutor` class resolved the path itself including any symlinks and eventually calls `/usr/bin/snap` instead of `/snap/bin/uv`. Snaps assumes a call to it's own CLI and fails. With this patch, the shell will resolve the path and provide the correct "executed file" information (`$0` in a Bash script) to Snap. fixes #282 b9ad0d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uvis installed via Snap on Ubuntu. Snap is a wrapper providing a safe environment for execution.Snap symlinks all executable commands to it's binary.
snap: Snap CLIThe
UvExecutorclass resolved the path itself including any symlinks and eventually calls/usr/bin/snapinstead of/snap/bin/uv. Snaps assumes a call to it's own CLI and fails.With this patch, the shell will resolve the path and provide the correct "executed file" information (
$0in a Bash script) to Snap.fixes #282
Description of changes
Replace this text with a description of the changes proposed in this PR, including the motivation for these changes and a reference to any related GitHub issue or discussion.
Pre-merge Checklist
poe checkexecuted successfully