Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use faster version of black #6133

Merged
merged 1 commit into from Aug 15, 2023
Merged

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Aug 10, 2023

Description

Use black compiled with mypyc instead of pure python version to get it faster

References

psf/black#3405

Type of change

  • Maintenance (changes required to run napari, tests, & CI smoothly)

@Czaki Czaki added the maintenance PR with maintance changes, label Aug 10, 2023
@Czaki Czaki added this to the 0.5.0 milestone Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #6133 (66f1517) into main (4ba0e6a) will decrease coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6133      +/-   ##
==========================================
- Coverage   91.62%   91.60%   -0.03%     
==========================================
  Files         579      579              
  Lines       50663    50701      +38     
==========================================
+ Hits        46419    46443      +24     
- Misses       4244     4258      +14     

see 2 files with indirect coverage changes

@Czaki
Copy link
Collaborator Author

Czaki commented Aug 10, 2023

@Carreau looks like #6086 is not working. I intentionally left a comment in this PR description, which was not removed.

@jni jni added the ready to merge Last chance for comments! Will be merged in ~24h label Aug 11, 2023
@Czaki Czaki added ready to merge Last chance for comments! Will be merged in ~24h and removed ready to merge Last chance for comments! Will be merged in ~24h labels Aug 14, 2023
@Czaki Czaki closed this Aug 14, 2023
@Czaki Czaki reopened this Aug 14, 2023
@GenevieveBuckley GenevieveBuckley merged commit c68d25f into napari:main Aug 15, 2023
30 checks passed
@Czaki Czaki deleted the faster_black branch August 15, 2023 09:54
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR with maintance changes,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants