Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning banner to older versions of documentation #82

Open
melissawm opened this issue Sep 27, 2022 · 11 comments
Open

Add warning banner to older versions of documentation #82

melissawm opened this issue Sep 27, 2022 · 11 comments
Labels
documentation Improvements or additions to documentation

Comments

@melissawm
Copy link
Member

📚 Documentation

From napari/napari#5096 (comment):

it would also be great if we had a nice colorful warning on the website that tells people that that's not the latest version (see for example the numpy docs)

@melissawm melissawm added the documentation Improvements or additions to documentation label Sep 27, 2022
@justinelarsen
Copy link

I think this is a much needed addition! Thanks for creating a separate issue @melissawm

It's interesting how the numpy docs only show the banner for versions 1.19 and older.

@melissawm
Copy link
Member Author

@codemonkey800 is this something you might be able to do in the napari-sphinx-theme?

@melissawm
Copy link
Member Author

Following up on this. Here's the current proposal to implement this directly into the pydata-sphinx-theme, and the related discussion

We can either wait for this to be implemented in the PyData Sphinx Theme and then cherrypick this into the napari sphinx theme, or echo that implementation in the napari theme right now, updating/removing it as it is merged into the PyData theme later. @codemonkey800 any thoughts?

@Nadalyn-CZI
Copy link
Contributor

I think this is a great idea. When can we do it?

@melissawm
Copy link
Member Author

Hi friends - here is a proof of concept using PyData Sphinx Theme's preliminary implementation:

https://melissawm.github.io/napari.github.io/0.4.15/index.html
https://melissawm.github.io/napari.github.io/0.4.16/index.html
https://melissawm.github.io/napari.github.io/0.4.17/index.html
https://melissawm.github.io/napari.github.io/dev/index.html

This is just a test, so I haven't enabled the banner in other pages, just the front page (ultimately I don't know that we want to have the warning here, but I just wanted to check that this would work.)

A few decisions are pending, for example the design which I'm not looking into at all so far.

This change will also involve multiple Pull Requests across the repos (napari/napari.github.io, napari/docs, napari/napari-sphinx-theme) and some manual tweaking of previous versions, which will only need to be done once. Because of this, I will wait for a definitive "go ahead" before doing anything.

@Nadalyn-CZI
Copy link
Contributor

Nadalyn-CZI commented Mar 3, 2023 via email

@melissawm
Copy link
Member Author

Sure! Like I said, design is still not a focus right now because I want to get a general "ok" first, but we certainly will need to think of that later.

@psobolewskiPhD
Copy link
Member

As we discussed at the meeting, I personally think this would be extremely useful and helpful. It's not hard to find either google links, tutorials, image.sc posts, or zulip posts that link to out-dated docs.
Minor comment: for the dev version, I think something other than latest would be clearer? At least to me, as a user that sounds like the latest, most recent release, but those are actually the dev docs for the unreleased main napari, which is experimental to say the least.

@seankmartin
Copy link
Contributor

I think that this would be great!

@psobolewskiPhD
Copy link
Member

Bumping for non-zulipers, @melissawm posted how this could be implemented with links to her fork!
https://napari.zulipchat.com/#narrow/stream/212875-general/topic/Version.20warning.20banner.20for.20documentation/near/353976623

Super exciting!

@psobolewskiPhD
Copy link
Member

Bumping this.
Looks like pydata theme did merge an implementation:
pydata/pydata-sphinx-theme#1354
I think we can "pick this up" with the new theme implementation:
napari/napari-sphinx-theme#134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants