Broken link on installation page for bundled app #5183
Comments
|
This link works for the |
|
See napari/napari.github.io#365, but there is about 92 broken links. Like just in your screenshot "as a Python package instead", should also be a link. |
Note that this is far from the only broken link, in the same issue, the
screenshot shows "as a Python package instead" that should also be a
link.
A quick way to see the number of non-existing links woudl be:
$ rg 'class="xref myst"' | cut -f1 -d: |cut -f1-2 -d'/' | uniq -c | sort -n
1 0.4.16/plugins
1 dev/plugins
2 0.4.15/index.html
2 0.4.16/index.html
2 0.4.16/tutorials
4 0.4.16/roadmaps
5 0.4.16/plugins
6 0.4.15/plugins
7 0.4.15/tutorials
8 0.4.16/roadmaps
9 0.4.15/developers
9 0.4.16/developers
12 0.4.15/guides
12 0.4.15/roadmaps
12 0.4.16/guides
Therefore there are potentially plenty of other links to fix in already
released version.
|
Ah, so many broken links! @Carreau Is there an issue already created to track all those broken links? Thanks for the quick PR to fix this one 😄 |
|
no, there is not. the question is: do we want to fix broken links in old
stable, or should we only ensure that new links are valid in future
releases.
…On Thu, Oct 6, 2022 at 19:41 Justine Larsen ***@***.***> wrote:
Ah, so many broken links! @Carreau <https://github.com/Carreau> Is there
an issue already created to track all those broken links? Thanks for the
quick PR to fix this one 😄
—
Reply to this email directly, view it on GitHub
<#5183 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACR5T2ZPHZRDKKAD5CG6PLWB4FLHANCNFSM6AAAAAAQ56SR4Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Good question! I don't know, but maybe best to create an issue to track it and then we can gather feedback on that issue to make a decision? The reason I found this was because a user was trying to install napari and had trouble finding the right instructions, so for right now, it is a problem for the stable docs, but I imagine that with time, this will become less of an issue. I would like to hear what others think. |
|
I mean broken links are obviously bad, so fixing them is good. But this can be semi-dealt with via a warning that the docs are out-dated, see napari/docs#82 |
|
Cool! Good to see #5008 going forward. Since 0.4.17 will be released soon, maybe the warning banner is more practical. Either way, I really like that proposed addition. |
|
This is fixed in every version of the live page on napari.org (0.4.15, 16, 17, and dev). |
📚 Documentation
There is "click here" text on this page that does not link anywhere.
https://napari.org/stable/tutorials/fundamentals/installation.html#prerequisites-for-installing-napari-as-a-bundled-app
"Click here to see instructions for installing the bundled app."
The "Click here" text should link to the bundled app installation section below on the same page (https://napari.org/stable/tutorials/fundamentals/installation.html#install-as-a-bundled-app).
The text was updated successfully, but these errors were encountered: