Skip to content

Commit

Permalink
Fixes transaction confirmations with the HttpProvider (web3#3140)
Browse files Browse the repository at this point in the history
* confirmations are now only emitted if a new block is actually existing

* CHANGELOG.md updated

* CHANGELOG.md 'Added' section updated with the added types

* build packages updated

* istanbul updated because of the usage of 'async', contract.js test codestyle improved, and transaction confirmation handling in the Method class of the web3-core-method module

* coveralls CI script updated

* coverage paths updated in e2e.ganache.sh, e2e.geth.automine.sh, e2e.geth.instamine.sh
  • Loading branch information
nivida authored and nachomazzara committed Jun 4, 2020
1 parent 4d02c63 commit f6e8c9e
Show file tree
Hide file tree
Showing 14 changed files with 1,013 additions and 1,142 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ Released with 1.0.0-beta.37 code base.
- Add `eth.getChainId` method (#3113)
- Minified file added to web3 package (#3131)
- The transaction confirmation workflow can now be configured (#3130)
- TypeScript type definitions added for all modules (#3132)
- Bloom filters added to web3.utils (#3137)

### Fixed
Expand All @@ -78,3 +79,4 @@ Released with 1.0.0-beta.37 code base.
- Signing issues #1998, #2033, and #1074 fixed (#3125)
- Fix hexToNumber and hexToNumberString prefix validation (#3086)
- The receipt will now returned on a EVM error (this got removed on beta.18) (#3129)
- Fixes transaction confirmations with the HttpProvider (#3140)
1,264 changes: 650 additions & 614 deletions package-lock.json

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@
}
],
"devDependencies": {
"@babel/core": "^7.6.0",
"@babel/preset-env": "^7.6.0",
"@babel/core": "^7.6.4",
"@babel/preset-env": "^7.6.3",
"@types/bignumber.js": "^4.0.2",
"@types/underscore": "^1.8.0",
"@types/bn.js": "^4.11.5",
Expand All @@ -82,9 +82,9 @@
"bluebird": "3.3.1",
"bn.js": "^4.11.8",
"bower": "1.8.8",
"browserify": "^16.3.0",
"browserify": "^16.5.0",
"chai": "^4.2.0",
"coveralls": "^3.0.4",
"coveralls": "^3.0.7",
"crypto-js": "^3.1.9-1",
"del": "^4.1.1",
"ethereumjs-common": "^1.3.2",
Expand All @@ -98,14 +98,14 @@
"gulp-babel": "^8.0.0",
"gulp-jshint": "^2.1.0",
"gulp-rename": "^1.4.0",
"gulp-replace": "^0.6.1",
"gulp-replace": "^1.0.0",
"gulp-streamify": "^1.0.2",
"gulp-uglify": "^3.0.2",
"istanbul": "^0.4.5",
"istanbul": "^1.1.0-alpha.1",
"istanbul-combine-updated": "^0.3.0",
"jshint": "^2.10.2",
"lerna": "^2.5.1",
"mocha": "^6.1.4",
"mocha": "^6.2.1",
"sandboxed-module": "^2.0.3",
"underscore": "^1.9.1",
"vinyl-source-stream": "^2.0.0",
Expand Down
4 changes: 1 addition & 3 deletions packages/web3-bzz/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f6e8c9e

Please sign in to comment.