Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helix editor config #274

Merged
merged 1 commit into from Oct 29, 2023
Merged

Conversation

rsjethani
Copy link
Contributor

@rsjethani rsjethani commented Jun 27, 2023

Helix editor version 23.10 changes the way language servers are configured. See https://helix-editor.com/news/release-23-10-highlights.

@mvdan
Copy link
Owner

mvdan commented Jun 27, 2023

Do you mean with Helix 23.05, or master? It seems like the config format changed with multi-lsp support: helix-editor/helix@71551d3

I think we want to document what works with stable, not the latest development version. And, as of 23.05, I still see this in the default languages file:

[[language]]
name = "go"
scope = "source.go"
injection-regex = "go"
file-types = ["go"]
roots = ["go.work", "go.mod"]
auto-format = true
comment-token = "//"
language-server = { command = "gopls" }
# TODO: gopls needs utf-8 offsets?
indent = { tab-width = 4, unit = "\t" }

I'm more than happy to merge once Helix does another release, though. Hopefully soon.

@rsjethani
Copy link
Contributor Author

Ohh yes! you are right @mvdan. I completely ignored the fact that I am using development version 😆

Sure lets merge later as you suggested. Thanks!

@rsjethani rsjethani changed the title FIX: Helix editor config Update Helix editor config Jun 28, 2023
@rsjethani
Copy link
Contributor Author

rsjethani commented Jun 28, 2023

I will update description and general PR tone to be a normal update rather than a bug fix once Helix version is out.

@mvdan
Copy link
Owner

mvdan commented Oct 27, 2023

The release is finally out :) Could you please double check that this config works with it, and update the commit message to explain that the release changed the config format?

Helix editor version 23.10 changes the way language servers are
configured. See https://helix-editor.com/news/release-23-10-highlights.
@rsjethani
Copy link
Contributor Author

@mvdan done!

Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvdan mvdan merged commit 4ac1be2 into mvdan:master Oct 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants